Anonymous donos from previous donors are using their previously listed alias

[jchesson1]

No description provided.

[jchesson1]

If a previous donor submits another donation with an anonymous alias, it shows up in the tracker listed under their previously used alias

[uraniumanchor]

What page does this occur on?

[jchesson1]

"Process Donations" & "Read Donations"

[informaniac]

Hello everyone. I hope this helps a little.

I have been investigating a similar issue and although I cannot reconstruct how this exact issue may have occurred (except if there was another anonymous donation by the donor after the pseudonymised donation), the following proposed solution for the other mentioned issue should fix this one, too.

Please note that the following might only be true in regard to donations via paypal. Also, I have not evaluated whether a set preferred email might affect this process, yet.

The problem seems to be that the Donation visibility is actually bound to the Donor object. This means that the Donor visibility changes with every other donation when the donator does not choose 'CURR' (use existing) for the requested visibility.
To me, this is not obvious, as I would expect a donation to stay anonymised when I add another pseudonymised donation after that (or vice versa).

A way to achieve this would be to handle the donation visibility on the Donation object (as the member exists anyway). But this adds some more things that would need to be addressed:

1. Donor creation. Currently the donator is only identified via paypal email, and the visibility handles the displayed donor name. A way around this could be to identify donors by email and name, which would increase the amount of Donor objects, but also increase privacy as alias and full name donations would be decoupled in the web view (as the donators email address is not shown on the donations page (as long as the donor does not have a preferred mail address?))
2. "Use existing" as visibility choice would not make sense anymore. What would be the expected outcome? The last choice? The highest level of details disclosed, yet?

I will try to experiment a little more with this, but it is currently not so easy as the paypal sandbox donations don't seem to be processed by the backend in my local dev environment which causes the Donor creation part to be skipped and leaving me with 'pending' transactions.

[faultyserver]

FYI, a stop-gap solution for this is likely going to happen in #556. The main thing we want to address is donation readers being shown a name different from what was entered on the donation form and incidentally saying names of people who don't want to be attributed. This PR will not affect any of the list pages like /tracker/donations, but will at least improve the highest-impact area, where names are being read on stream.