Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Switch for automatic IP printing #121

Open
mpustovoi opened this issue Aug 28, 2024 · 9 comments
Open

[Suggestion] Switch for automatic IP printing #121

mpustovoi opened this issue Aug 28, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@mpustovoi
Copy link
Contributor

I suggest having a switch in the mod settings that will automatically execute the command /worldhost ip so that modpack user doesn't have to perform additional actions that the user doesn't know about.
Personally, I use your mod along with Custom LAN, so I've never seen your mod's screen. If there is a hint on it, then I'll pass it and then consider it's more of a compatibility problem with Custom LAN, as mentioned in #1.
I see it as something like:
Automatically print IPNo/Only tunneling IP/Only temporary IP/Both.

@Gaming32
Copy link
Owner

The thing with the temporary IP is that it only works up to 60 seconds from when you run the command. It is temporary, after all. I'll consider adding the other thing though.

@Gaming32 Gaming32 added the enhancement New feature or request label Aug 28, 2024
@mpustovoi
Copy link
Contributor Author

mpustovoi commented Aug 28, 2024

Oh, got it.
I thought that the temporary IP only applies to the current gaming session.

@Gaming32
Copy link
Owner

/worldhost ip works until you close the game. If you leave the world and host a new one, the /worldhost ip will be the same. /worldhost tempip, on the other hand, only works for 60 seconds. It also only works if you have UPnP enabled and your router supports it.

@mpustovoi
Copy link
Contributor Author

So, if I close the game completely, next time when I enter my world /worldhost ip will give me new IP, right?
I'm just asking to know, since the minimap mod requires the same IP to save the world map as the same one, and not consider it as a different server.

@Gaming32
Copy link
Owner

Yes, it will give you a new IP. I do realize that this can cause issues with minimaps, but it's not really solvable without integrations from those minimap mods (which will shortly become easier).

@mpustovoi
Copy link
Contributor Author

It's a shame that those aren't open source.

@Gaming32
Copy link
Owner

Some are. I'll probably PR support into other mods that need world identification though, such as Bobby or Distant Horizons.

@Gaming32
Copy link
Owner

Though I just realized that the "easier way" actually doesn't help at all.

@mpustovoi
Copy link
Contributor Author

Maybe it can be done via playerdata or something, but I'm generally just a Minecraft player, so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants