Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetManager: Setting numConnections will result in numConnections always being 1 #1120

Closed
2jfw opened this issue Jan 9, 2025 · 3 comments
Closed

Comments

@2jfw
Copy link

2jfw commented Jan 9, 2025

AssetManager:
Setting numConnections will result in numConnections always being 1.
This is due to the Setter using a MathUtil.min:

public function set numConnections(value:int):void
{
    _numConnections = MathUtil.min(1, value);
}

I would think that it was ment to be MathUtil.max to use the highest injected value, but never go below "1".

@PrimaryFeather
Copy link
Contributor

Oh my! Good find, @2jfw. I clearly never tested that. 🙉

I'll fix that - thanks a lot for pointing me at it. 👍

@2jfw
Copy link
Author

2jfw commented Jan 9, 2025

Awesome, much appreciated, Daniel! 👍

Also, many thanks for still taking care of as3 Starling! ❤

@PrimaryFeather
Copy link
Contributor

I just committed the fix, @2jfw! Thanks again - for making me aware of this, and for the nice words. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants