Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why the fuck did i fork cc-rs? (make us cargo-install-able) #49

Closed
Tracked by #60
Gankra opened this issue Jul 1, 2024 · 1 comment · Fixed by #58
Closed
Tracked by #60

why the fuck did i fork cc-rs? (make us cargo-install-able) #49

Gankra opened this issue Jul 1, 2024 · 1 comment · Fixed by #58
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@Gankra
Copy link
Owner

Gankra commented Jul 1, 2024

cc = { version = "1.0.73", git = "https://github.com/Gankra/cc-rs" }

I'm guessing this was because cc-rs at the time expected to only be run from build.rs, where it should spew a million special directives to stdout, and it was a mess. Especially because I wanted stdout clean.

We use cc-rs because it abstracts away the details of running cc or a specific compiler toolchain on any platform, which is not code I personally want to write.

It would be ideal for this to not be forked so abi-cafe could actually be published on crates.io...

@Gankra Gankra added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Jul 1, 2024
@Gankra Gankra mentioned this issue Jul 7, 2024
@Gankra
Copy link
Owner Author

Gankra commented Jul 7, 2024

Fork is here: Gankra/cc-rs@0f6c1fd

I think all of this is now redundant except the redirect of stderr, which is required when compilers spit out errors to stderr.

@Gankra Gankra changed the title why the fuck did i fork cc-rs? why the fuck did i fork cc-rs? (make us cargo-install-able) Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant