Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty response contains one empty row, should contain none #53

Open
jheeffer opened this issue Apr 3, 2021 · 0 comments
Open

Empty response contains one empty row, should contain none #53

jheeffer opened this issue Apr 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@jheeffer
Copy link
Member

jheeffer commented Apr 3, 2021

https://big-waffle.gapminder.org/sg-master/d90f64d?_select_key@=country;&value@=world/_4region;;&from=entities&where_$and@_un/_state:true;&_world/_4region=africa

This response should not contain the inner empty array in rows

{
  "version": "d90f64d",
  "header": [
    "country",
    "world_4region"
  ],
  "rows": [

  ],
  "info": [
    {
      "msg": "DB found 0 records",
      "time": "2021-04-03T13:29:55.756Z"
    }
  ]
}

This should also be reflected in vizabi-ddfservice-reader, which now returns a response with one empty row.

@angiehjort angiehjort added the bug Something isn't working label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants