Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to modify the "RSVP" block #589

Open
1 of 3 tasks
Tracked by #557
carstingaxion opened this issue Mar 7, 2024 · 1 comment
Open
1 of 3 tasks
Tracked by #557

Need a way to modify the "RSVP" block #589

carstingaxion opened this issue Mar 7, 2024 · 1 comment
Labels
blocks enhancement New feature or request

Comments

@carstingaxion
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

Hello GatherPress crew!

I'd love to have the ability to rename the existing Attending block. And further on, to style it.

This has nothing to do with translations, but with restrictions of the current button-implementation as it does not allow an editor to change the Button-Text itself. Maybe someone prefers Join us or Take part over Attending, but there is no way to change this.

This impossibility to modify basic stuff also took place as I wanted to change any styling. I expected all the controls, that buttons usually have (allowed within the current theme), but found nothing.

Maybe it would be a better approach to not create a custom block from scratch, but instead use a button-block variation. This would prevent GatherPress from the ongoing maintenance burden, to keep those custom blocks close to their core-equivalents. Having just variations allows to add needed functionality, while still having everything common UI elements in place, if theme and user-role allow for it. This is also true for the button and the query-loop blocks. I highly encourage everybody to consider creating block-variations from core-blocks instead of custom blocks, especially with the rise of the Block Bindings API or the Interactivity API.

  • Have you considered using a block-variation for the Attending block?
  • What where the reasons for creating a custom block?

Thanks in advance.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@carstingaxion carstingaxion added the enhancement New feature or request label Mar 7, 2024
@mauteri mauteri moved this to Next Release in GatherPress Project Mar 7, 2024
@mauteri
Copy link
Contributor

mauteri commented Mar 7, 2024

@carstingaxion Funny, I was thinking of this flexibility too and have some ideas that are inline with the ticket #573 which I started on but haven't gotten very far with. I plan on discussing some ideas at our next meeting on Friday.

Reason it is a custom block is because it's pretty dynamic. Clicking the Edit RSVP will pull up a modal with additional actions a user can take. These actions also broadcast changes to the RSVP Attendance block which reacts with updates to the RSVP block. It's also important to note that this block is one of the first things we built 4 or so years ago, so many things have changed since then. I'm very open to ways of improving the maintainability of our blocks, but just need everyone to understand how they function (and will need to continue to function) if we make a big change like that. If it's possible to leverage the buttons block here in a seamless way that maintains the current functionality, then I'm all for that.

Let's discuss more on Friday or over Slack if you are unable to make the meeting. Thx!

@mauteri mauteri moved this from Next Release to Icebox in GatherPress Project Jun 14, 2024
@carstingaxion carstingaxion changed the title Need a way to modify the "Attending" block Need a way to modify the "RSVP" block Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocks enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants