Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks register_taxonomy_for_object_type #946

Open
1 task done
shawfactor opened this issue Oct 13, 2024 · 1 comment
Open
1 task done

Breaks register_taxonomy_for_object_type #946

shawfactor opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shawfactor
Copy link

Describe the bug

The plugin currently breaks the register_taxonomy_for_object_type, it is likely causing other problems as well.

Basically if I do

register_taxonomy_for_object_type( 'category', 'page', 100000 );

The category taxonomies functionality does not work properly, The taxonomy appears in the menu but not in the list table (it is not in screen options) and an error occurs in the block editor. See screenshots of both attached.

This occurs on a blank instll so its not a conflict with another plugin.

The issue is something to do with the settings functionality as if I comment out lines 124 and 139 in class-base.php then the issue goes away (but then the settings don't work). Can this be fixed urgently please?

no_category_colum
error

Steps to Reproduce

Install on blank installation
use register_taxonomy_for_object_type
View the post type listing and try to edit the applicable post type

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@shawfactor shawfactor added the bug Something isn't working label Oct 13, 2024
@carstingaxion
Copy link
Collaborator

carstingaxion commented Oct 13, 2024

Hello @shawfactor ,

let me know please, which WP and GatherPress versions you’re running?

From the outside, the base settings class and the registration of taxonomies per post type does not have much in common.
Also interesting is, that you’re able to fix it by disabling the base settings, which hasn’t been touched in 7 months.

At first, let’s see how to make this reproduceable!

  1. What does the browser console say, when the error appears?
  2. Can you provide a Playground link with the setup you described?

@GatherPress GatherPress deleted a comment Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@carstingaxion @shawfactor and others