Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit messages for specific fragments and/or length #68

Open
gkapfham opened this issue Sep 13, 2018 · 5 comments
Open

Check commit messages for specific fragments and/or length #68

gkapfham opened this issue Sep 13, 2018 · 5 comments

Comments

@gkapfham
Copy link
Collaborator

The current implementation of GatorGrader can only count the number of commits in a repository past a certain number. However, it would also be useful if the tool could look for fragments inside of a commit message. For instance, one idea would be that students must add a numerical rating for their level of frustration associated with that commit. Alternatively, GatorGrader could check to see if the commit messages contain an emoji in them (perhaps from a set list of emoji). Finally, it might be a good idea to introduce checks that can ensure that commit messages have a minimum or a maximum number of characters in them. Of course, if we introduce this type of feature, then we would also have to explain to students how to revise their commit messages so that they meet the standard that we are asking them to follow.

@gkapfham gkapfham changed the title Add feature to check commit messages for specific fragments and/or length Check commit messages for specific fragments and/or length Sep 13, 2018
@baldeosinghm
Copy link
Contributor

Currently working on this issue to check if commit messages meet a length requirement.

@gkapfham
Copy link
Collaborator Author

Hello @baldeosinghm can you please update as to whether or not you finished working on a PR that resolves this issue? Your note is the last one in the issue tracker and thus I wanted to check with you today! Thanks for any updates that you can share!

@gkapfham
Copy link
Collaborator Author

I wanted to write that I plan to implement this feature in the next few days. @quigley-c and @baldeosinghm if you would like to review the PR for this work, please let me know. Thanks!

@gkapfham
Copy link
Collaborator Author

I plan to work on this issue after implementing the new "linting-style" interface to GatorGrader.

@gkapfham gkapfham self-assigned this Jun 20, 2019
@gkapfham
Copy link
Collaborator Author

@Michionlion I have put this issue on hold until after we implement the linting interface. My view is that, currently, adding this feature would require me to change the command-line interface, which I would prefer not to do and then have to change once we implement the linting approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants