Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App goes behind iPhone X notch in Landscape mode #2642

Closed
6 tasks done
brownieboy opened this issue Mar 24, 2019 · 2 comments · May be fixed by actionhero/actionhero-react-native-example#33
Closed
6 tasks done

App goes behind iPhone X notch in Landscape mode #2642

brownieboy opened this issue Mar 24, 2019 · 2 comments · May be fixed by actionhero/actionhero-react-native-example#33

Comments

@brownieboy
Copy link

brownieboy commented Mar 24, 2019

I have gone through these following points

Issue Description

node, npm, react-native, react and native-base version, expo version if used, xcodeversion

Node: v8.11.1
NPM: 5.6.0
"dependencies": {
"native-base": "^2.12.1",
"react": "16.8.3",
"react-native": "0.59.1"
},

Expected behaviour

Safe area should work in Portrait and Landscape modes

Actual behaviour

Safe area only works in Portrait mode. In Landscape mode, the app partially disappears behind the notch (see screenshots below).

Steps to reproduce

Simple test repository here: https://github.com/brownieboy/nbiphonexheadertest

Is the bug present in both iOS and Android or in any one of them?

iOS and then only on devices with the notch. Tested on iPhone X Simulator. (Don't have real hardware to test.)

Any other additional info which would help us debug the issue quicker.

portrait
landscape

If I wrap the <Container> in a react-native <SafeAreaView>, it fixes the Landscape mode issue, but it messes up the <Header> height in Portrait mode, see #2440.

@SupriyaKalghatgi
Copy link
Contributor

Commit 167e2d1

@tspike
Copy link

tspike commented Mar 25, 2020

I encountered this issue in the context of #2947, where you can't use this fix without getting a warning about nested VirtualizedLists. My workaround is described here: #2947 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants