Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Hooks Update #2857

Closed
6 tasks done
danieloprado opened this issue Aug 8, 2019 · 7 comments
Closed
6 tasks done

React Hooks Update #2857

danieloprado opened this issue Aug 8, 2019 · 7 comments
Labels

Comments

@danieloprado
Copy link
Contributor

I have gone through these following points

Issue Description

It's is a proposal, we could migrate to use the new React Hooks Api, it's totally compatible with the current code and it can run side by side, I've created a pull request to demonstrate how simple it is and we could do it component by component with no rush.

Reasons:

  • Better Performance
  • Simplify the code
  • Easy Maintainability
  • With the new StyleProviderContext will be easy to third party libs to use the theme variables.
@sankhadeeproy007
Copy link
Contributor

@danieloprado That sounds like a great plan. We've been discussing the move to Hooks for a while now and the timing of your PR couldn't have been better!
Will take a look at the PR soon. Also roping in @sanketsahusoft for any inputs.

@danieloprado
Copy link
Contributor Author

Also fix #2832

@danieloprado
Copy link
Contributor Author

@sankhadeeproy007 Thank you! If you move on with this idea I'm glad to help you guys to update the code.

@Sampath-Lokuge
Copy link

Hi @danieloprado Is this library support React Hooks? It seems not according to the doc? e.g. https://docs.nativebase.io/Components.html#button-def-headref

@johntimothybailey
Copy link

@Sampath-Lokuge @akhil-geekyants Is this PR not being merged due to https://github.com/GeekyAnts/nativebase-v3

@TawalMc
Copy link

TawalMc commented Jan 2, 2021

Hi. What about the migration to React hook of NativeBase? Want to be part of contributor if is possible.

@stale
Copy link

stale bot commented Feb 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 3, 2022
@stale stale bot closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants