Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending verification code in POST body? #26

Open
sdob opened this issue Sep 12, 2018 · 2 comments
Open

Sending verification code in POST body? #26

sdob opened this issue Sep 12, 2018 · 2 comments

Comments

@sdob
Copy link

sdob commented Sep 12, 2018

Hi,

The component is great, and is about 99% perfect for our use case; thanks for writing it! We'd like to be able to send the verifier and token to our loginUrl endpoint in the request body — rather than in the query string — like so:

{"oauth_verifier" "xxxxxxx", "oauth_token": "xxxxxxx"}

We've forked it to do so, but obviously we'd rather contribute upstream than maintain our own fork. :-) Would you be willing to consider a fleshed-out pull request with the request style (query vs. body) as an optional prop?

@ivanvs
Copy link
Contributor

ivanvs commented Sep 18, 2018

Hi @sdob,

Sorry for late response. I was on vacation and I was not using my laptop :D

I would be very interested to accept your PR. Please, feel free to create PR. I will do some testing and merge it into master.

I really appreciate your effort.

@Kif11
Copy link

Kif11 commented Jun 24, 2019

I have to clone and modify this component because it was missing this feature.
Sending data in URL parameters for POST seams wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants