Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for ggplot2 labels change #69

Open
gravesti opened this issue Jan 31, 2025 · 0 comments · May be fixed by #72
Open

fix for ggplot2 labels change #69

gravesti opened this issue Jan 31, 2025 · 0 comments · May be fixed by #72

Comments

@gravesti
Copy link
Collaborator

cf /tests/testthat/test-plots.R#L92-L158

ggplot2 is removing the labels component we are testing against. tidyverse/ggplot2#6290

Solution could be to use the new get_labs() tidyverse/ggplot2#6078 eg

p <- ggplot(mpg, aes(displ, hwy)) +
  geom_point(aes(colour = drv, shape = drv))

get_labs(p)
@gravesti gravesti linked a pull request Feb 19, 2025 that will close this issue
69 fix for ggplot2 labels change #72
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

69 fix for ggplot2 labels change Genentech/psborrow
1 participant
@gravesti