Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and test-gmt-dev slash commands not working properly #1816

Closed
weiji14 opened this issue Mar 14, 2022 · 1 comment · Fixed by #1866
Closed

Format and test-gmt-dev slash commands not working properly #1816

weiji14 opened this issue Mar 14, 2022 · 1 comment · Fixed by #1866
Assignees
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@weiji14
Copy link
Member

weiji14 commented Mar 14, 2022

Description of the problem

The /format and /test-gmt-dev slash commands added in #646 and #831 respectively seem to have stopped working like they used to, and probably for a while now to be honest. I think GitHub made some changes in regard to bot permissions some time ago (though I can't pin an exact date), and a lot of these tools with auto-commit functionality just broke.

To be specific:

  1. For the /format command, an action is triggered and runs to completion, but no formatting commit actually happens. E.g.:
  1. The /test-gmt-dev command, I think it does run (?), but you have to jump to the 'Actions' tab to see it run which is very inconvenient. From memory, I think there was another problem with how it wasn't testing the changes in the PR branch properly, but some rebased commit instead? E.g.:

So, we'll either need to update these convenience slash commands, or remove them.

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Mar 14, 2022
@seisman seisman self-assigned this Mar 17, 2022
@seisman seisman added this to the 0.6.1 milestone Mar 18, 2022
@seisman
Copy link
Member

seisman commented Mar 24, 2022

2. The /test-gmt-dev command, I think it does run (?), but you have to jump to the 'Actions' tab to see it run which is very inconvenient.

Possible solution at peter-evans/slash-command-dispatch#87 (comment).

Or we can simply post the run job id (maybe https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}) to the /test-gmt-dev comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants