Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Python 3.8 compatibility #340

Closed
seisman opened this issue Oct 10, 2019 · 3 comments · Fixed by #398
Closed

Check Python 3.8 compatibility #340

seisman opened this issue Oct 10, 2019 · 3 comments · Fixed by #398
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Oct 10, 2019

Description of the problem

Python 3.8 is scheduled to be released on 2019-10-14. We need to check if pygmt works well with Python 3.8.

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Oct 10, 2019
@weiji14
Copy link
Member

weiji14 commented Oct 10, 2019

Not sure whether our upstream dependencies have Python 3.8 compatibility but won't hurt to try.

Referencing similar previous issue for Python 3.7 #190.

@leouieda
Copy link
Member

We can wait for conda-forge to start building packages for it. No one is going to update so soon and we probably won't have any issues since we don't use the parts of the code base that change a lot.

@weiji14 weiji14 added this to the 0.1.0 milestone Nov 15, 2019
@weiji14
Copy link
Member

weiji14 commented Nov 15, 2019

Just been cross-referencing our conda requirements at

numpy
pandas
xarray
netCDF4
packaging
with https://conda-forge.org/status/ and I think most packages have Python 3.8 compatibility now? Will need to test things out to be sure. Adding this to the v0.1.0 milestone.

Also, it would be good to take note of the Python version deprecation policies at PEP 606 -- Python Compatibility Version, and NEP 29 — Recommend Python and Numpy version support as a community policy standard. The latter recommends supporting at least two of the latest minor versions of Python and the inclusion of the following text somewhere in our project's development guidelines:

This project supports:

  • All minor versions of Python released 42 months prior to the project, and at minimum the two latest minor versions.
  • All minor versions of numpy released in the 24 months prior to the project, and at minimum the last three minor versions.

which in practice means:

On Jun 23, 2020 drop support for Python 3.6 (initially released on Dec 23, 2016)
On Dec 26, 2021 drop support for Python 3.7 (initially released on Jun 27, 2018)
On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

See also http://xarray.pydata.org/en/stable/installing.html#minimum-dependency-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants