Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let grdcut support xarray.DataArray as inputs #496

Closed
seisman opened this issue Jun 28, 2020 · 0 comments · Fixed by #541
Closed

Let grdcut support xarray.DataArray as inputs #496

seisman opened this issue Jun 28, 2020 · 0 comments · Fixed by #541
Labels
feature request New feature wanted upstream Bug or missing feature of upstream core GMT
Milestone
0.2.0

Comments

@seisman
Copy link
Member

seisman commented Jun 28, 2020

Description of the desired feature

The grdcut() wrapper was implemented in PR #492 and was already merged into master. However, it can't accept xarray.DataArray as input, due to a missing feature in GMT 6.0.0.

After GMT 6.1.0 is released, grdcut() should be able to take xarray.DataArray as input.

Are you willing to help implement and maintain this feature? Yes
@seisman seisman added feature request New feature wanted upstream Bug or missing feature of upstream core GMT labels Jun 28, 2020
@weiji14 weiji14 added this to the 0.2.x milestone Jul 7, 2020
This was referenced Jul 21, 2020
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature wanted upstream Bug or missing feature of upstream core GMT
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Let grdcut() accept xarray.DataArray as input GenericMappingTools/pygmt
2 participants
@seisman @weiji14