Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for Session.write_data() after bumping to GMT 6.1.1 #557

Closed
seisman opened this issue Aug 7, 2020 · 0 comments · Fixed by #583
Closed

Add a test for Session.write_data() after bumping to GMT 6.1.1 #557

seisman opened this issue Aug 7, 2020 · 0 comments · Fixed by #583
Labels
maintenance Boring but important stuff for the core devs upstream Bug or missing feature of upstream core GMT
Milestone
0.2.0

Comments

@seisman
Copy link
Member

seisman commented Aug 7, 2020

Description of the problem

See PR #556 and review #556 (comment) for context.

In short, Session.write_data() can write a netCDF grid for a matrix grid. We need to add a test to check it works.
@seisman seisman added maintenance Boring but important stuff for the core devs upstream Bug or missing feature of upstream core GMT labels Aug 7, 2020
@seisman seisman added this to the 0.2.x milestone Aug 7, 2020
@seisman seisman mentioned this issue Sep 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs upstream Bug or missing feature of upstream core GMT
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Add a test for Session.write_data() writing netCDF grids GenericMappingTools/pygmt
1 participant
@seisman