Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "make clean" #737

Closed
seisman opened this issue Dec 15, 2020 · 1 comment · Fixed by #744
Closed

Improve "make clean" #737

seisman opened this issue Dec 15, 2020 · 1 comment · Fixed by #744
Labels
feature request New feature wanted
Milestone

Comments

@seisman
Copy link
Member

seisman commented Dec 15, 2020

Description of the problem

Running make clean can delete some temporary files and directories, but I usually have two problems with it:

  1. make clean doesn't delete the files in doc/_build directory. IMHO, it should.
  2. make clean deletes the .egg-info directory, so I have to reinstall pygmt in editable mode again (am I right here?)

Solution:

  1. make clean should delete doc/_build directory but do NOT delete the .egg-info directory
  2. Add a new target make dist-clean (or spotless or other better names) to delete all these files, including .egg-info directory.

Are you willing to help implement and maintain this feature?
Yes, but let's discuss it first.

@seisman seisman added the feature request New feature wanted label Dec 15, 2020
@seisman
Copy link
Member Author

seisman commented Dec 17, 2020

https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html

clean and distclean are the standard targets in Makefile. I think we can following the rules, and let make distclean delete the .egg-info diretcory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant