-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues of the "Publish to PyPI" workflow #901
Comments
Ok, renaming
You sure we want to hardcode disabling Github Actions workflows for forks? I know we can add a
|
I meant to add this line to the "Publish to PyPI" workflow, because forks can't do the uploads anyway (they don't have the tokens), and we also don't want to see projects like pygmt-01, pygmt-forks on PyPI. |
For other workflows (e.g., Tests and GMT Dev Tests), I think they're disabled for forks by default but can be enabled following the documentation you just posted. |
Description of the problem
The
publish-to-pypi.yml
workflow uploads the PyGMT packages to PyPI and/or TestPyPI.During the release v0.3.0, we found an issue with the workflow and had a quick fix in #900.
When I reiviwed the workflow, I found two more issues:
test_pypi_password
andpypi_password
in thepypa/gh-action-pypi-publish
action.pygmt/.github/workflows/publish-to-pypi.yml
Lines 54 to 64 in 65b099a
The names of these two secrets are confusing. They are API tokens (generated by me, if I remember correctly), not someone's passwords. We should rename them to better names,
TEST_PYPI_API_TOKEN
andPYPI_API_TOKEN
following the official guide.The text was updated successfully, but these errors were encountered: