Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inputs + outputs consistent, provide general serializer #22

Open
jsstevenson opened this issue Dec 26, 2024 · 0 comments
Open

Make inputs + outputs consistent, provide general serializer #22

jsstevenson opened this issue Dec 26, 2024 · 0 comments
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@jsstevenson
Copy link
Member

Feature description

  • Different fetchers handle things like text normalization slightly differently. I think we should always just be forcing our expected enums.
  • Make sure that inputs for things like search terms always look the same (e.g. as types)
  • Make a type util kind of method to recursively dump something like nested namedtuples and enums into a more easily jsonable type.

Use case

End users may want simpler datatypes when eg merging outputs into a dataframe

Acceptance Criteria

Open ended, but

  • do a review of all top level fetch methods and identify + resolve inconsistencies
  • 'normalization' should always happen (no optional)
  • make a jsonify() or dictify() method that strips namedtuple and enum types

Proposed solution

No response

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

None

@jsstevenson jsstevenson added enhancement New feature or request priority:medium Medium priority labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

1 participant