Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/room waiting #149

Merged
merged 7 commits into from
Apr 10, 2021
Merged

Feature/room waiting #149

merged 7 commits into from
Apr 10, 2021

Conversation

BilelJegham
Copy link
Member

Closes #89

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #149 (bd5212a) into master (14dd468) will decrease coverage by 0.07%.
The diff coverage is 12.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   34.36%   34.28%   -0.08%     
==========================================
  Files          31       32       +1     
  Lines        1004     1015      +11     
  Branches      187      185       -2     
==========================================
+ Hits          345      348       +3     
- Misses        655      663       +8     
  Partials        4        4              
Impacted Files Coverage Δ
src/components/DialogSummary.vue 15.78% <0.00%> (ø)
src/components/HeaderGame.vue 33.33% <ø> (ø)
src/components/dialogroom/DialogRoom.vue 22.13% <0.00%> (-0.82%) ⬇️
src/components/game/DetailsMap.vue 33.33% <ø> (ø)
...omponents/history/gameResult/HistoryMapClassic.vue 0.00% <ø> (ø)
...omponents/history/gameResult/HistoryMapCountry.vue 8.00% <ø> (ø)
src/components/home/SearchBox.vue 82.35% <ø> (ø)
src/components/home/maps/MapCard.vue 100.00% <ø> (ø)
src/components/home/maps/MapDialog.vue 100.00% <ø> (ø)
src/components/map/Map.vue 53.70% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acd581...bd5212a. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review April 10, 2021 17:09
@BilelJegham BilelJegham merged commit 7b450ad into master Apr 10, 2021
@BilelJegham BilelJegham deleted the feature/room-waiting branch April 10, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flexible room size
1 participant