Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Record #161

Merged
merged 2 commits into from
Apr 23, 2021
Merged

fix: Record #161

merged 2 commits into from
Apr 23, 2021

Conversation

BilelJegham
Copy link
Member

Closes #141

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #161 (c8e6d4f) into master (93f14e7) will increase coverage by 2.97%.
The diff coverage is 53.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   34.28%   37.25%   +2.97%     
==========================================
  Files          32       35       +3     
  Lines        1015     1130     +115     
  Branches      185      207      +22     
==========================================
+ Hits          348      421      +73     
- Misses        663      703      +40     
- Partials        4        6       +2     
Impacted Files Coverage Δ
src/components/DialogSummary.vue 18.75% <ø> (+2.96%) ⬆️
src/components/HeaderGame.vue 33.33% <ø> (ø)
.../components/dialogroom/card/CardRoomPlayerName.vue 4.76% <0.00%> (-0.80%) ⬇️
...omponents/history/gameResult/HistoryMapClassic.vue 0.00% <ø> (ø)
...omponents/history/gameResult/HistoryMapCountry.vue 8.00% <ø> (ø)
src/pages/Home.vue 100.00% <ø> (ø)
src/components/Maps.vue 19.40% <12.50%> (+0.42%) ⬆️
...omponents/history/gameResult/HistoryTimeDetail.vue 16.66% <16.66%> (ø)
...rc/components/dialogroom/card/CardRoomSettings.vue 12.00% <33.33%> (-1.05%) ⬇️
src/components/dialogroom/DialogRoom.vue 22.76% <50.00%> (+0.63%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00556f5...c8e6d4f. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review April 23, 2021 07:23
@BilelJegham BilelJegham merged commit c30f90e into master Apr 23, 2021
@BilelJegham BilelJegham deleted the fix/141-home-record branch May 19, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Record becomes 0 when playing Country Mode
1 participant