Missing __version__ in generated python module

[MuellerSeb]

I noticed, that maturin doesn't add a __version__ string to the generated module.

One possibility is given here: PyO3/maturin#100 (comment)

    m.add("__version__", env!("CARGO_PKG_VERSION"))?;

See also here: https://github.com/PyO3/pyo3-built/

[MuellerSeb]

Also https://github.com/PyO3/pyo3-built/ would be a good thing to include, I guess.
What do you think, @LSchueler @adamreichold ?

[adamreichold]

I am admittedly somewhat sceptical. Having inline provenance data is certainly nice, but do we have a specific use case in mind? Adding a build script does have a cost w.r.t. build duration and additional failure modes. (But then our build configuration uses LTO and a single codegen unit, so build times already are horrible.)

Personally, I would start with the minimal version info as suggested in the top comment.

[MuellerSeb]

Ok. Then I would suggest adding version info and making a release so we can release gstools 1.3.4

[LSchueler]

Hmm, that's a tough one. Reproducibility is maybe even more important in scientific software than in other software and detailed environment info about versions, backend, ... definitely helps in that regard. But even longer build times do sound horrible.
So yeah, maybe start out with only adding the version info and afterwards we could experiment with the pyo3-built.

[LSchueler]

I'm closing this for now due to PR #17.