-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for geographical coordinates #113
Conversation
…d earth rad constant
…ials section in README
…ing with lat-lon data
…escaled length as start
@LSchueler this should be ready for a first review! 🥳 |
Strangely all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that is quite some addition, great!
I think that we are almost good to go. Just some minor changes I hinted at in the code comments. I also think that the unittests are enough.
I'm going to push some typo fixes directly on this branch again as always ;-) So don't forget to pull before working on this again.
… into latlon_support
lat-lon support
This PR introduces the long-awaited support for geographic coordinates given by latitude an longitude.
CovModel
latlon
to indicate a geographic model. When given, spatial dimension is fixed todim=3
,anis
andangles
will be ignored, since anisotropy is not well-defined on a sphere.field_dim
to indicate the dimension of the resulting field. Will be 2 iflatlon=True
zeta
:vario_yadrenko
: given byvariogram(2 * np.sin(zeta / 2))
cov_yadrenko
: given bycovariance(2 * np.sin(zeta / 2))
cor_yadrenko
: given bycorrelation(2 * np.sin(zeta / 2))
isometrize
andanisometrize
methods will convertlatlon
tuples (given in degree) to points on the unit-sphere in 3D and vice versadim
,anis
andangles
parameters, butlatlon=True
fit_variogram
will expect an estimated variogram with great-circle distances given in radiansVariogram estimation
latlon
switch implemented inestimate_vario
routineField
"unstructured"
keyword is recognized, everything else is interpreted as"structured"
(e.g."rectilinear"
)Misc
EARTH_RADIUS
as constant providing earths radius in km (can be used to rescale models)latlon2pos
andpos2latlon
to convert lat-lon coordinates to points on unit-sphere and vice versaExamples
TODO