Load buffer or arraybuffer in load function

[ghost]

Is your feature request related to a problem? Please describe.

My tiff file is in the local system. I would like to load buffer or arraybuffer instead of giving url to load function.
By looking at the code it seems pretty simple to implement this feature

async function load (urlOrFile) {

  if (!inBrowser && typeof urlOrFile === 'object') {
    throw new Error(ERROR_LOAD_FILE_OUTSIDE_BROWSER);
  }

  const url = typeof urlOrFile === 'object' ? URL.createObjectURL(urlOrFile) : urlOrFile;

  if (!cache[url]) {
    const response = await fetchWithErrorHandling(url);
    const arrayBuffer = await toArrayBuffer(response);
    const georaster = await parseGeorasterWithErrorHandling(arrayBuffer);
    cache[url] = georaster;
  }
  return cache[url];
}

export default load;

I am running this code in node.

Describe the solution you'd like

I would like to add a PR to accept a buffer or array buffer as an input.

[DanielJDufour]

Hi, @rahulbreezo . Good idea! A Pull Request would be much appreciated! Thank you!

[ghost]

Thanks, will do that ASAP.

[sudoStatus200]

@rahulbreezo is my work account.
@DanielJDufour Hi, I was thinking How should I take buffer input?

1. I can create a new small function just to accept arrayBuffer then call parseGeorasterWithErrorHandling
   or
2. In the same load function I can accept a second argument option where user can specify the type of input( buffer, arraybuffer, url).

like this

load($arraybyffer, {type: arraybuffer});

//or
load($arraybyffer, {type: buffer});

//or
load($url, {type: url});

Can you suggest which approach should I pick? In my opinion I think I should go with the 2nd approach.

[DanielJDufour]

I know it's a lot to ask, but could we try to make it work, so that it automatically determines the type of input and processes it accordingly. In other words, make it so the following work:

load(arrayBuffer); 
load(buffer); // NodeJS' buffer https://nodejs.org/api/buffer.html
load(url);
load(file); // https://developer.mozilla.org/en-US/docs/Web/API/File

I sorta see load as a higher level functions that makes it easier for users to give anything to load and it works. Here's a few functions that might help.

• Buffer.isBuffer: https://www.w3schools.com/nodejs/met_buffer_isbuffer.asp
• instanceof ArrayBuffer

Let me know what you think!

[sudoStatus200]

I also wanted to do the same thing but then I checked Buffer.isBuffer does not work in the browser, So I thought I would take option param in the load where the user itself mention the input type.

But no problem, I will make it work as you said.

[DanielJDufour]

Thank you!