Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Tuba does not support pasting an Image to a post #411

Closed
2 of 4 tasks
kop316 opened this issue Jul 24, 2023 · 5 comments · Fixed by #413
Closed
2 of 4 tasks

[Request]: Tuba does not support pasting an Image to a post #411

kop316 opened this issue Jul 24, 2023 · 5 comments · Fixed by #413
Labels
enhancement New feature or request

Comments

@kop316
Copy link
Contributor

kop316 commented Jul 24, 2023

Describe the request

If someone uses Phosh to take a screenshot, it is copied to the clipboard vs. saved to disk: https://gitlab.gnome.org/World/Phosh/phosh/-/issues/964

We should probably be able to take a copied image and paste it to a new post.

Implementation Details

  • This should be an option in settings.
  • This should be only available to some fediverse backends. (Include which ones on the above field).
  • This is client-only (and shouldn't sync with the instance).
  • This follows the GNOME HIG.
@kop316 kop316 added the enhancement New feature or request label Jul 24, 2023
@LukaszH77
Copy link
Contributor

Oh, yes, that would be great! And you made me think it would be nice to drag and drop images onto Tuba's main window to create a new post with them, or onto the composer window to add images to the post being edited/created.

@GeopJr
Copy link
Owner

GeopJr commented Jul 25, 2023

Could use some testing: #413 (drag n drop included)

Pasting a file path (/ if you copy (a) file(s) from nautilus) should also work as long as Tuba has access to the file.

it would be nice to drag and drop images onto Tuba's main window to create a new post with them

Drag and drop will only work if you dnd an image into the media tab of the composer. Drag and dropping (or pasting) anywhere on Tuba doesn't sound that safe considering the way posting media works is by first uploading them to the server and then attaching their IDs to the post (/ if you accidentally paste/dnd a sensitive image it will be uploaded to the server)

edit:

@kop316 how does pasting work on mobile? The current implementation expects you to press CtrlV, does mobile use something else? I'll ask on the phosh issue

@LukaszH77
Copy link
Contributor

LukaszH77 commented Jul 26, 2023

D'n'd works like a charm, thank you.

Ctrl+V doesn't work on the media tab, and on the text tab it just pastes file paths.

feat/composer/media/clipboard-paste-ae62401

@GeopJr
Copy link
Owner

GeopJr commented Jul 26, 2023

Thanks for testing! Ctrl+V won't work between Nautilus and Flatpak Tuba (unless Tuba has access to the files) because it doesn't use a portal. It should work with textures however (Take a screenshot with the default GNOME Screenshot tool and paste it in Tuba)

@LukaszH77
Copy link
Contributor

Tried it yesterday and again today on feat/composer/media/clipboard-paste-3c734a1 and pasting a screenshot doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants