Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Build broken on vala 0.56.11 #446

Closed
harmathy opened this issue Aug 17, 2023 · 1 comment · Fixed by #447
Closed

[Bug]: Build broken on vala 0.56.11 #446

harmathy opened this issue Aug 17, 2023 · 1 comment · Fixed by #447
Labels
bug Something isn't working

Comments

@harmathy
Copy link
Contributor

harmathy commented Aug 17, 2023

Describe the bug

I use the AUR package and Vala compiler on Arch Linux was recently updated from 0.56.8 to 0.56.11, which breaks the build.

Steps To Reproduce

see above

Logs and/or Screenshots

../Tuba/src/Widgets/VoteBox.vala:75.17-75.39: warning: `Gtk.CssProvider.load_from_data' has been deprecated since 4.12
   75 |                 provider.load_from_data (generate_css_style ((int) percentage).data);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~                                              
../Tuba/src/Widgets/VoteBox.vala:75.42-75.83: error: Argument 1: Cannot convert from `unowned uint8[]' to `unowned string'
   75 |                 provider.load_from_data (generate_css_style ((int) percentage).data);
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  
../Tuba/src/Widgets/VoteBox.vala:75.17-75.84: error: 1 missing arguments for `void Gtk.CssProvider.load_from_data (string, ssize_t)'
   75 |                 provider.load_from_data (generate_css_style ((int) percentage).data);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
../Tuba/src/Widgets/VoteBox.vala:76.17-76.37: warning: `Gtk.Widget.get_style_context' has been deprecated since 4.10
   76 |                 row.get_style_context ().add_provider (provider, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION);
      |                 ^~~~~~~~~~~~~~~~~~~~~                                                                     
Compilation failed: 2 error(s), 2 warning(s)
[44/167] Linking target tests/Celebrate
ninja: build stopped: subcommand failed.

Instance Backend

Mastodon

Operating System

Arch Linux

Package

Compiled manually

Troubleshooting information

n/a

Additional Context

Workaround:

  • downgrade to vala 0.56.8
  • build
  • after successful build vala can be safely updated
@GeopJr
Copy link
Owner

GeopJr commented Aug 17, 2023

Thanks for raising this issue!

That probably shouldn't have landed in a patch release of Vala :/

I'll attempt to backport it and make a patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants