Refactoring PyShp to support py.typed marker file. #371
Replies: 1 comment
-
Example branch demonstrating Option B): https://github.com/GeospatialPython/pyshp/tree/Option-B)-Trivial-single-file-package-(src/shapefile/__init__.py) Example branch demonstrating possible Option C): https://github.com/GeospatialPython/pyshp/tree/Option-C)-Multiple-file-package-(src/shapefile/%7B__init__%2Creader%2Cwriter%2Cgeoson%2C.%7D.py) |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Thomas (@dl1jbe) raised a great point (#367), that by adding py.typed, I broke typechecking for users using PyShp together with non-statically typed deps, so for now I've simply deleted py.typed (PyShp v3.0.2).
Other than not breaking our user's workflows, I have no strong opinions, just a mild preference for option C. But I wanted to gather everyone's thoughts about complying (or not) with the current typing system spec for distribution https://typing.python.org/en/latest/spec/distributing.html#packaging-type-information. In a nutshell, the spec states we must refactor from the single file module PyShp's always been, to a package.
This year, together with Mike (@mwtoews) , the repo was refactored already, from a flat layout to src format.
I believe this leaves us with the following options.
1 vote ·
Beta Was this translation helpful? Give feedback.
All reactions