Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvester should use file format as resource title when no title is provided #2027

Closed
jvitello opened this issue Jul 24, 2017 · 2 comments
Closed

Comments

@jvitello
Copy link

jvitello commented Jul 24, 2017

User story

As a Site Manager, when I harvest data from a source that does not provide titles for resources/distributions, I should see the format of the file used as the title, rather than the URL, so that it is easier to read.

Original Request

Datasets being harvested are being titled with relative link titles, which do not accurately reflect their content, request research into possible alternatives.

Description

We think the client is referencing the behavior where if no title exists for a distribution in a data.json harvest, the url is used as the title in DKAN. We'd like to use the filename instead, or use the file type as the title if no file name can be isolated.

POD schema for distributions:
https://project-open-data.cio.gov/v1.1/schema/#distribution

Steps to Reproduce

  • create a resource with the attached data.json
  • harvest using the resource download link
  • review the resource titles

Acceptance Criteria

  • If a data.json distribution does not include a title, use the file name as the title
  • If a title can't be determined use the file format as the title "{{file type}} File"

Tests

We should add php unit tests to make sure all of this is happening correctly.

@dangur dangur assigned dangur and unassigned dangur Jul 24, 2017
@kimwdavidson kimwdavidson changed the title harvested resource titles when no title available Harvester should use file format as title when no title is available Dec 6, 2017
@kimwdavidson kimwdavidson changed the title Harvester should use file format as title when no title is available Harvester should use file format as title when no title is provided Dec 6, 2017
@kimwdavidson kimwdavidson changed the title Harvester should use file format as title when no title is provided Harvester should use file format as resource title when no title is provided Dec 6, 2017
@kimwdavidson kimwdavidson added the B2 label Dec 6, 2017
@janette janette assigned janette and unassigned dafeder Dec 15, 2017
@janette janette added In Progress and removed ready labels Dec 15, 2017
@janette janette assigned fmizzell and dafeder and unassigned janette and fmizzell Dec 15, 2017
@kimwdavidson
Copy link

Blocked by PHP unit tests

@fmizzell
Copy link
Contributor

The issues with the unit tests will be dealt in #2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants