Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore tables should be generated as innodb tables #2698

Closed
acouch opened this issue Oct 17, 2018 · 8 comments
Closed

Datastore tables should be generated as innodb tables #2698

acouch opened this issue Oct 17, 2018 · 8 comments
Assignees
@dharizza

Comments

@acouch
Copy link
Contributor

acouch commented Oct 17, 2018 •
edited
Loading

The new datastore is missing a step to add full-text to strings. The new datastore does not add types for columns so we would want to full-text all of the columns or do some discovery for strings. The old code is https://github.com/GetDKAN/feeds_flatstore_processor/blob/master/feeds_flatstore_processor.module#L168

Additionally the API docs include q (string) – fulltext search when it should be "query", not "q".

After addressing this we could also close #2042
@erogray
Copy link

erogray commented Apr 23, 2019

@janette to bring up with PQDC team

@janette
Copy link
Member

janette commented Apr 24, 2019

search across all columns

@erogray
Copy link

erogray commented Apr 30, 2019

@acouch is this a documentation need? Or a shortcoming of Recline? Or both?
Or is this not relevant for D7?

1 similar comment
@erogray
Copy link

erogray commented May 21, 2019

@acouch is this a documentation need? Or a shortcoming of Recline? Or both?
Or is this not relevant for D7?

@erogray erogray assigned acouch and unassigned janette May 21, 2019
@erogray
Copy link

erogray commented May 30, 2019

@acouch ^

@erogray
Copy link

erogray commented Jun 11, 2019

@janette to bring up with PQDC team

@janette
Copy link
Member

janette commented Jun 12, 2019

To do: switch the datastore tables to innodb

@janette janette changed the title New Datastore doesn't include Full-text search Datastore tables should be generated as innodb tables Jul 30, 2019
@erogray
Copy link

erogray commented Aug 21, 2019

New datastore tables are being generated as InnoDB, this can be considered done

@erogray erogray closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dharizza dharizza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janette @acouch @dharizza @erogray