Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pattern & components - Header -> Sidebar -> Page -> Footer #893

Open
si4star opened this issue May 26, 2022 · 2 comments
Open

New pattern & components - Header -> Sidebar -> Page -> Footer #893

si4star opened this issue May 26, 2022 · 2 comments

Comments

@si4star
Copy link

si4star commented May 26, 2022

I'm surprised to see the Page component. The semantic approach to producing a page would be Header -> Content -> Footer - so the concept of a Page element doesn't really fit my understanding of good semantics.

It would be bad practice to break the page over two components

Header Component =

Footer Component =

Header Component where the Title, subtitles and intro all modified based on route but the general header structure remains the same

where the page or views content sites

Footer Component = The end of the page - be it a footer or whatever closes your correctly

Header and Footer components could be extended - or app headers could include Atlantis headers.

I'm also surprised to see there are no navigation or sidebar elements despite that structure being used on getjobber.com (sidebar/header/navigation) and the report scheduler (header/navigation).

I think this is a really important area to address if you want developers to use Atlantis - as at the moment it just gets messy if I try to use the Page pattern you're suggesting.

@si4star
Copy link
Author

si4star commented May 26, 2022

#729 would cover some of this potentially

@si4star si4star changed the title New component or pattern - Header & Sidebar New pattern & components - Header -> Sidebar -> Page -> Footer Jun 4, 2022
@si4star
Copy link
Author

si4star commented Jun 4, 2022

I've heavily edited this issue in order to highlight structural issues with the pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant