feat: add type hints to php #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdeme
requested review from
AnatolyRugalev and
ferhatelmas
as code owners
peterdeme
force-pushed
the
add-typing
branch
6 times, most recently
from
f5841aa to
5e6c7d9
Compare
| @@ -1,34 +1,36 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=0); | |||
There was a problem hiding this comment.
Not sure if it's worth adding type hints when they are not strict
There was a problem hiding this comment.
@AnatolyRugalev I do not intend to introduce a breaking change now. I plan to enable it in the next major version.
Let's say that the type hints are just warnings for now.
peterdeme
commented
Feb 8, 2022
Comment on lines
-66
to
-71
| public function testCreateTokenExpirationThrowsIfNotUnixTimestamp() | ||
| { | ||
| $this->expectException(\GetStream\StreamChat\StreamException::class); | ||
| $expires = new DateTime(); | ||
| $this->client->createToken("tommaso", $expires); | ||
| } |
There was a problem hiding this comment.
this test fails with TypeError so I needed to drop it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.