You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's really difficult to edit text styles to match our brand. I have custom text styles that I want, such as a custom font family. However, stream has so many text node styles that it would take so many hours to set the text styles for all of them.
Proposed solution
Add a text field, similar to colors, inside of style. All text nodes would inherit from this, and would be overridden at the theme level.
Acceptance Criteria
Since React Native often needs a different font-family per weight, maybe the API could look like this:
Something like:
conststyle={fontFamily: {// any time stream uses fontWeight, it should instead do fontFamily: style.fontFamily[weight]default: 'arial',600: 'arial-bold',},text: {// all text nodes inherit this stylefontFamily: 'arial'}}
Here I add fontFamily and text as keys to style. If Stream's internals want to set bold text, they should do fontFamily: style.fontFamily.bold in the text style.
Also, all Text nodes could set the style.text as their base style, allowing all text nodes to easily set a font family.
Curious to get feedback.
The text was updated successfully, but these errors were encountered:
Motivation
It's really difficult to edit text styles to match our brand. I have custom text styles that I want, such as a custom font family. However, stream has so many text node styles that it would take so many hours to set the text styles for all of them.
Proposed solution
Add a
text
field, similar tocolors
, inside ofstyle
. All text nodes would inherit from this, and would be overridden at the theme level.Acceptance Criteria
Since React Native often needs a different font-family per weight, maybe the API could look like this:
Something like:
Here I add
fontFamily
andtext
as keys tostyle
. If Stream's internals want to set bold text, they should dofontFamily: style.fontFamily.bold
in the text style.Also, all
Text
nodes could set thestyle.text
as their base style, allowing all text nodes to easily set a font family.Curious to get feedback.
The text was updated successfully, but these errors were encountered: