You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
groupStyles mislabels messages whose create time is sufficiently after the previous message and that follow "single" messages. Labelled "Bottom" when should be "top" or "single".
#2374
Open
flyaflya opened this issue
Jan 4, 2024
· 0 comments
The logic for groupStyles mislabels messages where the previous message is "single" and the difference in the current and previous messages' create time is longer than the maxTimeBetweenGroupedMessages.
These messages should be labelled either "Top" or "Single", but they are getting labelled as "bottom".
I believe the code can be fixed by adding the last line to this code snippet:
flyaflya
changed the title
groupStyles mislabels messages whose create time is sufficiently after the previous message and that following "single" messages. Labelled "Bottom" When should be "top" or "single".
groupStyles mislabels messages whose create time is sufficiently after the previous message and that follow "single" messages. Labelled "Bottom" When should be "top" or "single".
Jan 4, 2024
flyaflya
changed the title
groupStyles mislabels messages whose create time is sufficiently after the previous message and that follow "single" messages. Labelled "Bottom" When should be "top" or "single".
groupStyles mislabels messages whose create time is sufficiently after the previous message and that follow "single" messages. Labelled "Bottom" when should be "top" or "single".
Jan 4, 2024
Issue
The logic for groupStyles mislabels messages where the previous message is "single" and the difference in the current and previous messages' create time is longer than the
maxTimeBetweenGroupedMessages
.These messages should be labelled either "Top" or "Single", but they are getting labelled as "bottom".
I believe the code can be fixed by adding the last line to this code snippet:
I have testted this fix by sending a fixed component,
getMessagesGroupStyles={getGroupStyles}
and it seems to work perfectly.Steps to reproduce
Steps to reproduce the behavior:
maxTimeBetweenGroupedMessages={40000}
The text was updated successfully, but these errors were encountered: