Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings: unchecked Sendable, non-async makeConnectedUser, and unused variables #3555

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

laevandus
Copy link
Contributor

🎯 Goal

Seeing less warnings

📝 Summary

  • Compiler requires to add unchecked Sendable
  • makeConnectedUser is not async anymore (oversight from PR:3550)
  • Unused variables in tests

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus added the 🤖 CI/CD Any work related to CI/CD label Jan 9, 2025
@laevandus laevandus requested a review from a team as a code owner January 9, 2025 14:04
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.98 MB 6.98 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

Copy link

github-actions bot commented Jan 9, 2025

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 1.67 ms 83.3% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 0.66 ms per s 83.5% 🔼 🟢
Frame rate 75 fps 78.21 fps 4.28% 🔼 🟢
Number of hitches 1 0.2 80.0% 🔼 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.98 MB 6.98 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@laevandus laevandus merged commit 8b5e108 into develop Jan 9, 2025
14 checks passed
@laevandus laevandus deleted the fix/various-warnings branch January 9, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants