Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): integration test for button component #1394

Merged
merged 2 commits into from
Mar 5, 2019
Merged

feat(button): integration test for button component #1394

merged 2 commits into from
Mar 5, 2019

Conversation

atlwendy
Copy link
Contributor

@atlwendy atlwendy commented Mar 5, 2019

closes #1281

@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #1394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +<.01%     
==========================================
  Files          92       92              
  Lines        3560     3562       +2     
  Branches      524      524              
==========================================
+ Hits         3537     3539       +2     
  Misses         23       23
Impacted Files Coverage Δ
terminus-ui/button/src/button.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f63d1f...689cc12. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1394      +/-   ##
==========================================
+ Coverage   99.35%   99.35%   +<.01%     
==========================================
  Files          92       92              
  Lines        3560     3562       +2     
  Branches      524      525       +1     
==========================================
+ Hits         3537     3539       +2     
  Misses         23       23
Impacted Files Coverage Δ
terminus-ui/button/src/button.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f63d1f...c9173ed. Read the comment docs.

benjamincharity
benjamincharity suggested changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@benjamincharity benjamincharity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These conversions are going to give us so much more confidence in our components. Love it 🎉

Functionally looks great - just a couple test statements that should be worded differently 😬

terminus-ui/button/src/button.component.spec.ts Outdated

describe(`when format === collapsable`, () => {
test(`button is not disabled`, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few test statements here that should start with should...

terminus-ui/button/src/button.component.spec.ts Outdated
});

test(`showProgress is false`, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not a needed change, but for future reference, feel free to combine on/off tests like these into a single test

@atlwendy atlwendy force-pushed the 1281-button-integration-test branch from c9173ed to e2ed6e2 Compare March 5, 2019 16:47
@atlwendy atlwendy requested a review from benjamincharity March 5, 2019 16:49
@benjamincharity benjamincharity merged commit 1a34e18 into master Mar 5, 2019
@benjamincharity benjamincharity deleted the 1281-button-integration-test branch March 7, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincharity benjamincharity benjamincharity approved these changes

@shani-terminus shani-terminus Awaiting requested review from shani-terminus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button: Convert to integration test
2 participants
@atlwendy @benjamincharity