Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ValidationMessages): tests are converted to integration #1558

Merged
merged 2 commits into from
Jun 18, 2019

Conversation

shani-terminus
Copy link
Contributor

ISSUES CLOSED: #1297

@shani-terminus shani-terminus force-pushed the 1297-validationMessages-convert-tests-int branch 2 times, most recently from e96e294 to ca33e07 Compare June 17, 2019 12:32
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #1558 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1558   +/-   ##
========================================
  Coverage    98.72%   98.72%           
========================================
  Files          126      126           
  Lines         4328     4328           
  Branches       610      609    -1     
========================================
  Hits          4273     4273           
  Misses          55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0106c...ca33e07. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #1558 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1558   +/-   ##
========================================
  Coverage    98.72%   98.72%           
========================================
  Files          126      126           
  Lines         4328     4328           
  Branches       572      572           
========================================
  Hits          4273     4273           
  Misses          55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c1846...95abe7b. Read the comment docs.

@shani-terminus shani-terminus force-pushed the 1297-validationMessages-convert-tests-int branch from ca33e07 to e5fc990 Compare June 17, 2019 12:39
@benjamincharity benjamincharity merged commit 43025e2 into release Jun 18, 2019
@benjamincharity benjamincharity deleted the 1297-validationMessages-convert-tests-int branch June 21, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidationMessages: Convert to integration test
2 participants