Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): enforce node 11 usage to match dockerfile #1605

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

benjamincharity
Copy link
Contributor

ISSUES CLOSED: #1581

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #1605 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1605   +/-   ##
========================================
  Coverage    98.81%   98.81%           
========================================
  Files          126      126           
  Lines         4797     4797           
  Branches       832      798   -34     
========================================
  Hits          4740     4740           
  Misses          57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96180b5...c2c741d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release@b589b4e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             release    #1605   +/-   ##
==========================================
  Coverage           ?   98.81%           
==========================================
  Files              ?      126           
  Lines              ?     4797           
  Branches           ?      798           
==========================================
  Hits               ?     4740           
  Misses             ?       57           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b589b4e...d244c86. Read the comment docs.

@benjamincharity benjamincharity merged commit c7ed782 into release Jul 23, 2019
@benjamincharity benjamincharity deleted the 1581-update-node-engine branch July 23, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change node engine to require v11
2 participants