Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): click on 2nd autocomplete, 1st panel should be closed #1673

Merged

Conversation

atlwendy
Copy link
Contributor

closes #1671

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #1673 into release will decrease coverage by 0.01%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #1673      +/-   ##
===========================================
- Coverage    95.54%   95.53%   -0.02%     
===========================================
  Files          127      127              
  Lines         4850     4860      +10     
  Branches       809      812       +3     
===========================================
+ Hits          4634     4643       +9     
- Misses         216      217       +1
Impacted Files Coverage Δ
...tocomplete-panel/autocomplete-trigger.directive.ts 87.79% <90%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0409a6...f1783ba. Read the comment docs.

@benjamincharity benjamincharity merged commit eacf941 into release Aug 30, 2019
@benjamincharity benjamincharity deleted the 1671-autocomplete-panel-closes-click-anywhere branch September 26, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete panel should close if clicking anywhere else
2 participants