feat(link): Allow email links without the external icon #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release #1695 +/- ##
===========================================
+ Coverage 95.73% 95.73% +<.01%
===========================================
Files 130 130
Lines 5200 5207 +7
Branches 895 862 -33
===========================================
+ Hits 4978 4985 +7
- Misses 217 222 +5
+ Partials 5 0 -5
Continue to review full report at Codecov.
|
benjamincharity
suggested changes
Sep 16, 2019
| /** | ||
| * Decide whether an external icon should be shown | ||
| */ | ||
| @Input() |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| public get destination(): string | string[] | undefined { | ||
| return this._destination; | ||
| } | ||
| public set destination(value: string | string[] | undefined) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| return this._destination; | ||
| } | ||
| public set destination(value: string | string[] | undefined) { | ||
| if (typeof (value) === 'string' && (value.includes('mailto') || value.includes('tel'))) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
atlwendy
force-pushed
the
1627-ts-link-allow-email-links
branch
from
4bfa626 to
767443c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1627