Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select): fix box height when label floats #1721

Merged
merged 2 commits into from
Sep 26, 2019
Merged

fix(Select): fix box height when label floats #1721

merged 2 commits into from
Sep 26, 2019
+0 −4

Conversation

atlwendy
Copy link
Contributor

image

@atlwendy atlwendy requested a review from a team as a code owner September 26, 2019 16:20
@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited
Loading

Codecov Report

Merging #1721 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1721   +/-   ##
========================================
  Coverage    96.07%   96.07%           
========================================
  Files          131      131           
  Lines         5227     5227           
  Branches       893      893           
========================================
  Hits          5022     5022           
  Misses         205      205

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47fea5e...d55699e. Read the comment docs.

@benjamincharity benjamincharity changed the title fix(select): fix box height when label floats fix(Select): fix box height when label floats Sep 26, 2019
@benjamincharity benjamincharity merged commit 3c7008a into release Sep 26, 2019
@benjamincharity benjamincharity deleted the 1718-select-box-misalign branch September 26, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincharity benjamincharity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atlwendy @benjamincharity