Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormControls: Support 'no validation' mode #1752

Closed
14 tasks
benjamincharity opened this issue Oct 23, 2019 · 0 comments · Fixed by #2005
Closed
14 tasks

FormControls: Support 'no validation' mode #1752

benjamincharity opened this issue Oct 23, 2019 · 0 comments · Fixed by #2005
Assignees
@atlwendy
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Oct 23, 2019 •
edited by atlwendy
Loading

There are times where controls don't need a validation or a hint. We should add an @Input so that the space below the control is not reserved for a validation message.

Examples of this:

  • Menu to select the number of records per page in the paginator
  • Menu to edit table columns
  • Remember me checkbox in log in form
  • SelectionList to change demo page
  • Add to all applicable controls:
    • NOT handling autocomplete
    • Checkbox
    • Input
    • Menu
    • RadioGroup
    • Select
    • SelectionList
    • Toggle
  • Add input noValidationOrHint = false
    • This will live on the individual components AND on the form field component. Components will need to forward this flag to the form field.
  • Flag is used for *ngIf on the validation messages component - AND to remove spacing under component.
    • The components will need to pass this flag to the formfield's matching input so that the form field component can adjust the spacing.
  • Default to false
  • Add test
  • Add to usage docs
  • Update components to use this flag
    • Menu to select the number of records per page in the paginator
    • Menu to edit table columns
    • Remember me checkbox in log in form
    • SelectionList to change demo page
    • Any others?
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist labels Oct 23, 2019
@atlwendy atlwendy self-assigned this Jan 28, 2020
@atlwendy atlwendy mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atlwendy atlwendy

Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(formControl): now form control supports no validation mode. GetTerminus/terminus-ui
2 participants
@benjamincharity @atlwendy