Skip to content

Commit 985c98a

Browse files
authored
Cleanup and standardize the READMEs (cometbft#482)
* changes.md -> changelog.md * add and standardize readmes * contrib link * fix repo root link * add detection link * light-node badges
1 parent db54050 commit 985c98a

File tree

9 files changed

+115
-67
lines changed

9 files changed

+115
-67
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ changes in the PR.
1010
* [ ] Updated all relevant documentation in docs
1111
* [ ] Updated all code comments where relevant
1212
* [ ] Wrote tests
13-
* [ ] Updated CHANGES.md
13+
* [ ] Updated CHANGELOG.md

CHANGES.md renamed to CHANGELOG.md

File renamed without changes.

CONTRIBUTING.md

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ of smaller incremental changes, in the form of small PRs that can be merged
5656
quickly. This helps manage the load for reviewers and reduces the likelihood
5757
that PRs will sit open for longer.
5858

59-
![Contributing flow](./docs/imgs/contributing.png)
59+
![Contributing
60+
flow](https://github.com/tendermint/tendermint/blob/v0.33.6/docs/imgs/contributing.png)
6061

6162
Each stage of the process is aimed at creating feedback cycles which align contributors and maintainers to make sure:
6263

@@ -87,19 +88,24 @@ To pull in updates from the origin repo, run
8788

8889
## Changelog
8990

90-
Every non-trivial PR must update the CHANGELOG.md.
91+
Every non-trivial PR must update the [CHANGELOG.md].
9192

92-
Changes for a given release should be split between the four sections: Breaking
93-
Changes, Features, Improvements, Bug Fixes.
93+
Changelog structure is modeled after
94+
[Tendermint
95+
Core](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md)
96+
and
97+
[Hashicorp Consul](http://github.com/hashicorp/consul/tree/master/CHANGELOG.md).
98+
See those changelogs for examples.
9499

95-
See the [changelog template](CHANGELOG.md).
100+
Changes for a given release should be split between the five sections: Security, Breaking
101+
Changes, Features, Improvements, Bug Fixes.
96102

97103
Changelog entries should be formatted as follows:
98104
```
99-
- [crate] \#xxx Some description about the change (@contributor)
105+
- [pkg] \#xxx Some description about the change (@contributor)
100106
```
101-
Here, `crate` is the part of the code that changed (typically a
102-
top-level crate), `xxx` is the pull-request number, and `contributor`
107+
Here, `pkg` is the part of the code that changed (typically a
108+
top-level crate, but could be <crate>/<module>), `xxx` is the pull-request number, and `contributor`
103109
is the author/s of the change.
104110

105111
It's also acceptable for `xxx` to refer to the relevent issue number, but pull-request
@@ -108,7 +114,7 @@ Note this means pull-requests should be opened first so the changelog can then
108114
be updated with the pull-request's number.
109115

110116
Changelog entries should be ordered alphabetically according to the
111-
`module`, and numerically according to the pull-request number.
117+
`pkg`, and numerically according to the pull-request number.
112118

113119
Changes with multiple classifications should be doubly included (eg. a bug fix
114120
that is also a breaking change should be recorded under both).

README.md

Lines changed: 27 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,36 +5,42 @@
55
[![Build Status][build-image]][build-link]
66
[![Audit Status][audit-image]][audit-link]
77
[![Apache 2.0 Licensed][license-image]][license-link]
8-
![Rust 1.39+][rustc-image]
8+
![Rust 1.44+][rustc-image]
99

10-
Rust crates for interacting with [Tendermint]: a high-performance blockchain
11-
consensus engine that powers Byzantine fault tolerant applications written
12-
in any programming language.
10+
[Tendermint] in Rust with [TLA+ specifications](/docs/spec).
1311

14-
Also includes [TLA+ specifications](/docs/spec).
12+
Tendermint is a high-performance blockchain consensus engine
13+
for Byzantine fault tolerant applications written in any programming language.
1514

16-
## Releases
15+
## Requirements
16+
17+
Tested with Rust 1.44+, may work on older version.
18+
19+
Compatible with the v0.33 series of [Tendermint Core][Tendermint].
20+
21+
## Documentation
1722

18-
Release tags can be found on
19-
[Github](https://github.com/informalsystems/tendermint-rs/releases).
23+
See each component for the relevant documentation.
2024

21-
Releases for each crate are published to crates.io:
25+
Libraries:
2226

23-
- [tendermint][tendermint-docs-link] - Tendermint data structures and
27+
- [tendermint](./tendermint) - Tendermint data structures and
2428
serialization
25-
- [tendermint-rpc][tendermint-rpc-docs-link] - Tendermint RPC client and
29+
- [tendermint-rpc](./rpc) - Tendermint RPC client and
2630
response types
27-
- [light-client][tendermint-light-client-docs-link] - Tendermint light client library for verifying
31+
- [light-client](./light-client) - Tendermint light client library for verifying
2832
signed headers, tracking validator set changes, and detecting forks
29-
- [light-node][tendermint-light-node-docs-link] - Tendermint light client binary
3033

31-
## Installation
34+
Binaries:
3235

33-
Requires Rust 1.39+
36+
- [light-node](./light-node) - Tendermint light node to synchronize with a
37+
blockchain using the light client
3438

35-
## Documentation
39+
## Releases
40+
41+
Release tags can be found on [Github](https://github.com/informalsystems/tendermint-rs/releases).
3642

37-
See documentation on [crates.io](#releases).
43+
Crates are released on crates.io.
3844

3945
## Contributing
4046

@@ -43,8 +49,8 @@ The Tendermint protocols are specified in English in the
4349
Any protocol changes or clarifications should be contributed there.
4450

4551
This repo contains the TLA+ specifications and Rust implementations for
46-
various components of Tendermint. If you're interested in contributing, please
47-
comment on an issue or open a new one!
52+
various components of Tendermint. See the [CONTRIBUTING.md][contributing] to start
53+
contributing.
4854

4955
## Versioning
5056

@@ -102,7 +108,7 @@ limitations under the License.
102108
[audit-link]: https://github.com/informalsystems/tendermint-rs/actions?query=workflow%3AAudit-Check
103109
[license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
104110
[license-link]: https://github.com/interchainio/tendermint-rs/blob/master/LICENSE
105-
[rustc-image]: https://img.shields.io/badge/rustc-1.39+-blue.svg
111+
[rustc-image]: https://img.shields.io/badge/rustc-1.44+-blue.svg
106112

107113
[//]: # (general links)
108114

@@ -111,4 +117,4 @@ limitations under the License.
111117
[Tendermint]: https://github.com/tendermint/tendermint
112118
[tendermint-light-client-docs-link]: https://docs.rs/tendermint-light-client/
113119
[tendermint-light-node-docs-link]: https://docs.rs/tendermint-light-node/
114-
120+
[contributing]: ./CONTRIBUTING.md
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Light Client Detection
2+
3+
This is a work in progress. There are two drafts.
4+
One from the view of a [light node](./detection.md)
5+
and one from the view of [IBC](./req-ibc-detection.md).
6+
They are both works in progress and may be consolidated.

light-client/README.md

Lines changed: 6 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
[![Crate][crate-image]][crate-link]
22
[![Docs][docs-image]][docs-link]
3-
[![Build Status][build-image]][build-link]
4-
[![Audit Status][audit-image]][audit-link]
5-
[![Apache 2.0 Licensed][license-image]][license-link]
6-
![Rust 1.44+][rustc-image]
73

8-
# Light-Client
9-
10-
Implementation of the [Light Client Verification Protocol][light-client-verification].
4+
See the [repo root] for build status, license, rust version, etc.
115

12-
## Requirements
6+
# Light-Client
137

14-
Tested with Rust 1.44+, may work on older versions.
8+
Implementation of the [Light Client Verification][light-client-verification]
9+
and [Fork Detection][light-client-detection] protocols.
1510

1611
## Documentation
1712

@@ -64,38 +59,17 @@ loop {
6459
}
6560
```
6661

67-
## License
68-
69-
Copyright © 2020 Informal Systems
70-
71-
Licensed under the Apache License, Version 2.0 (the "License");
72-
you may not use the files in this repository except in compliance with the License.
73-
You may obtain a copy of the License at
74-
75-
https://www.apache.org/licenses/LICENSE-2.0
76-
77-
Unless required by applicable law or agreed to in writing, software
78-
distributed under the License is distributed on an "AS IS" BASIS,
79-
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
80-
See the License for the specific language governing permissions and
81-
limitations under the License.
82-
8362
[//]: # (badges)
8463

8564
[crate-image]: https://img.shields.io/crates/v/tendermint-light-client.svg
8665
[crate-link]: https://crates.io/crates/tendermint-light-client
8766
[docs-image]: https://docs.rs/tendermint-light-client/badge.svg
8867
[docs-link]: https://docs.rs/tendermint-light-client/
89-
[build-image]: https://github.com/informalsystems/tendermint-rs/workflows/Rust/badge.svg
90-
[build-link]: https://github.com/informalsystems/tendermint-rs/actions?query=workflow%3ARust
91-
[audit-image]: https://github.com/informalsystems/tendermint-rs/workflows/Audit-Check/badge.svg
92-
[audit-link]: https://github.com/informalsystems/tendermint-rs/actions?query=workflow%3AAudit-Check
93-
[license-image]: https://img.shields.io/badge/license-Apache2.0-blue.svg
94-
[license-link]: https://github.com/interchainio/tendermint-rs/blob/master/LICENSE
95-
[rustc-image]: https://img.shields.io/badge/rustc-1.44+-blue.svg
9668

9769
[//]: # (general links)
9870

71+
[repo root]: https://github.com/informalsystems/tendermint-rs
9972
[quick start]: https://github.com/tendermint/tendermint/blob/master/docs/introduction/quick-start.md
10073
[Tendermint]: https://github.com/tendermint/tendermint
10174
[light-client-verification]: https://github.com/informalsystems/tendermint-rs/blob/master/docs/spec/lightclient/verification/verification.md
75+
[light-client-detection]: https://github.com/informalsystems/tendermint-rs/tree/master/docs/spec/lightclient/detection

light-node/README.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
[![Crate][crate-image]][crate-link]
2+
[![Docs][docs-image]][docs-link]
3+
4+
See the [repo root] for build status, license, rust version, etc.
5+
16
# Light-Node
27

38
The [Tendermint] light-node wraps the [light-client] crate into a command-line interface tool.
@@ -237,7 +242,17 @@ Example output:
237242

238243
</details>
239244

245+
[//]: # (badges)
246+
247+
[crate-image]: https://img.shields.io/crates/v/tendermint-light-node.svg
248+
[crate-link]: https://crates.io/crates/tendermint-light-node
249+
[docs-image]: https://docs.rs/tendermint-light-node/badge.svg
250+
[docs-link]: https://docs.rs/tendermint-light-node/
251+
252+
[//]: # (general links)
253+
240254

255+
[repo root]: https://github.com/informalsystems/tendermint-rs
241256
[quick start]: https://github.com/tendermint/tendermint/blob/master/docs/introduction/quick-start.md
242257
[Tendermint]: https://github.com/tendermint/tendermint
243-
[light-client]: https://github.com/informalsystems/tendermint-rs/tree/master/light-client
258+
[light-client]: https://github.com/informalsystems/tendermint-rs/tree/master/light-client

rpc/README.md

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
[![Crate][crate-image]][crate-link]
2+
[![Docs][docs-image]][docs-link]
3+
4+
See the [repo root] for build status, license, rust version, etc.
5+
16
# tendermint-rpc
27

38
A rust implementation of the core types returned by a Tendermint node's RPC
@@ -6,8 +11,9 @@ These can be used to deserialize JSONRPC responses.
611
All networking related features will be feature guarded to keep the dependencies small
712
in cases where only the core types are needed.
813

9-
Releases of this crate should be compatible to the same [tendermint] version as
10-
the [tendermint.rs] crate with the same version number.
14+
## Documentation
15+
16+
See documentation on [crates.io][docs-link].
1117

1218
## The `client` Feature
1319

@@ -21,6 +27,17 @@ To keep dependencies small when only the core types are needed, it has to be exp
2127
- RPC endpoints REST interface documentation:
2228
https://docs.tendermint.com/master/rpc/
2329

30+
[//]: # (badges)
31+
32+
[crate-image]: https://img.shields.io/crates/v/tendermint-rpc.svg
33+
[crate-link]: https://crates.io/crates/tendermint-rpc
34+
[docs-image]: https://docs.rs/tendermint-rpc/badge.svg
35+
[docs-link]: https://docs.rs/tendermint-rpc/
36+
37+
[//]: # (general links)
38+
39+
40+
[repo root]: https://github.com/informalsystems/tendermint-rs
2441
[tendermint]: https://github.com/tendermint/tendermint
2542
[core types]: https://github.com/tendermint/tendermint/blob/8b4a30fada85fccd8f0cb15009344f1cbd8de616/rpc/core/types/responses.go#L1
26-
[tendermint.rs]: https://crates.io/crates/tendermint
43+
[tendermint.rs]: https://crates.io/crates/tendermint

tendermint/README.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
[![Crate][crate-image]][crate-link]
2+
[![Docs][docs-image]][docs-link]
3+
4+
See the [repo root] for build status, license, rust version, etc.
5+
6+
# tendermint
7+
8+
Implementation of the [Tendermint] Blockchain Data Structures.
9+
10+
## Documentation
11+
12+
See documentation on [crates.io][docs-link].
13+
14+
[//]: # (badges)
15+
16+
[crate-image]: https://img.shields.io/crates/v/tendermint.svg
17+
[crate-link]: https://crates.io/crates/tendermint
18+
[docs-image]: https://docs.rs/tendermint/badge.svg
19+
[docs-link]: https://docs.rs/tendermint/
20+
21+
[//]: # (general links)
22+
23+
[repo root]: https://github.com/informalsystems/tendermint-rs
24+
[Tendermint]: https://github.com/tendermint/tendermint

0 commit comments

Comments
 (0)