Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GPHContent APIs with GiphyViewController #249

Open
simoalx opened this issue May 22, 2024 · 0 comments
Open

Allow GPHContent APIs with GiphyViewController #249

simoalx opened this issue May 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@simoalx
Copy link

simoalx commented May 22, 2024

Use case description

We want to have more customisation of the GiphyViewController, like we would have making the more low level GiphyGridController, e.g.

gridController.content = GPHContent.search(withQuery: "Sup", mediaType: .text, language: .english)
gridController.update()

Proposed solution

Add an API for GPHContent usage for GiphyViewController, or allow access to the underlying GiphyGridController for that vc (if it is implemented this way)

Alternatives considered

We could roll our own VC with all the more lower level components, but we'd lose the convenience of GiphyViewController.

@simoalx simoalx added the enhancement New feature or request label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant