Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Crash on didLongPressCell in Giphy Grid View #33

Closed
M1ST4KE opened this issue Oct 5, 2021 · 1 comment
Closed

[android] Crash on didLongPressCell in Giphy Grid View #33

M1ST4KE opened this issue Oct 5, 2021 · 1 comment

Comments

@M1ST4KE
Copy link

M1ST4KE commented Oct 5, 2021 •
edited
Loading

In file android/src/main/java/com/giphyreactnativesdk/GiphyGridViewManager.kt in method getSearchGridCallback are not implemented callbacks didLongPressCell and didTapUsername, which instead of doing nothing, are throwing TODO("not implemented") exception.
@M1ST4KE M1ST4KE mentioned this issue Oct 5, 2021
Merged
@pshoniuk
Copy link
Contributor

pshoniuk commented Oct 6, 2021

Hi @M1ST4KE, thanks for the report and work on the fix!
It should be fixed in v1.1.1

@pshoniuk pshoniuk closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@M1ST4KE @pshoniuk