-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS bottom row theme is wrong when device is in dark mode but theme prop is "light" #89
Comments
Hi @efstathiosntonas, thank you for the detailed report. |
Thanks @pshoniuk! keep it up! |
Hi @pshoniuk, any updates on this issue? Thanks |
Hi @efstathiosntonas! Sorry for the delayed response. We've prepared a fix for the iOS SDK and will release a fix for the React Native SDK next week. |
Great, thanks! |
Hi @efstathiosntonas, we released a fix in v2.1.1 |
Hi @pshoniuk, thanks, will try it asap. |
@pshoniuk totally forgot about it, it works as it should now, thanks for closing it. |
Don't worry. It's nice to hear that everything is working as expected! |
🐛 Bug Report
iOS bottom row theme is wrong when device is in dark mode but
theme
prop islight
.To Reproduce
(Write your steps here:)
light
theme prop onGiphyDialog
Expected behavior
I'm expecting the bottom row to be the same like when device is in light theme mode.
Actual Behavior
Bottom row colors are wrong when device is in dark mode but the
theme
prop islight
. Please see attached screenshots and device theme/prop theme combos:This is Device in dark mode,
theme
prop islight
:This is device light mode,
theme
proplight
:this is device light mode,
theme
propdark
:this is device dark mode,
theme
propdark
:Your Environment
2.1.0
0.68.5
16.1
16.1
The text was updated successfully, but these errors were encountered: