Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS bottom row theme is wrong when device is in dark mode but theme prop is "light" #89

Closed
efstathiosntonas opened this issue Dec 13, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@efstathiosntonas
Copy link

efstathiosntonas commented Dec 13, 2022

🐛 Bug Report

iOS bottom row theme is wrong when device is in dark mode but theme prop is light.

To Reproduce

(Write your steps here:)

  1. Set iPhone on dark mode from settings
  2. Use light theme prop on GiphyDialog
  3. Bottom row colors and background are wrong (sickers, emojis etc)

Expected behavior

I'm expecting the bottom row to be the same like when device is in light theme mode.

Actual Behavior

Bottom row colors are wrong when device is in dark mode but the theme prop is light. Please see attached screenshots and device theme/prop theme combos:

This is Device in dark mode, theme prop is light:

Screenshot 2022-12-13 at 08 55 55

This is device light mode, theme prop light:

Screenshot 2022-12-13 at 08 56 56

this is device light mode, theme prop dark:

Screenshot 2022-12-13 at 08 58 29

this is device dark mode, theme prop dark:

Screenshot 2022-12-13 at 08 59 09

Your Environment

  • Giphy React Native SDK version: 2.1.0
  • React Native version: 0.68.5
  • Platform(s) (iOS, Android, or both?): ios 16.1
  • Device info (Simulator/Device? OS version? Debug/Release?): iPhone 13 iOS 16.1
@efstathiosntonas efstathiosntonas added the bug Something isn't working label Dec 13, 2022
@pshoniuk
Copy link
Contributor

Hi @efstathiosntonas, thank you for the detailed report.
We will release a fix in the next version. When it becomes available, I will post the update here.

@efstathiosntonas
Copy link
Author

Thanks @pshoniuk! keep it up!

@efstathiosntonas
Copy link
Author

efstathiosntonas commented Dec 29, 2022

Hi @pshoniuk, any updates on this issue? Thanks

@pshoniuk
Copy link
Contributor

pshoniuk commented Jan 4, 2023

Hi @efstathiosntonas! Sorry for the delayed response. We've prepared a fix for the iOS SDK and will release a fix for the React Native SDK next week.

@efstathiosntonas
Copy link
Author

Great, thanks!

@pshoniuk
Copy link
Contributor

Hi @efstathiosntonas, we released a fix in v2.1.1

@efstathiosntonas
Copy link
Author

Hi @pshoniuk, thanks, will try it asap.

@efstathiosntonas
Copy link
Author

@pshoniuk totally forgot about it, it works as it should now, thanks for closing it.

@pshoniuk
Copy link
Contributor

Don't worry. It's nice to hear that everything is working as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants