Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files saved at 1kb #123

Closed
StrangeDOS opened this issue Dec 28, 2022 · 3 comments
Closed

Files saved at 1kb #123

StrangeDOS opened this issue Dec 28, 2022 · 3 comments

Comments

@StrangeDOS
Copy link

Describe the bug
All files created are just empty 1kb files.

To Reproduce
Steps to reproduce the behavior:
comics-downloader -url=https://readcomiconline.li/Comic/52

Expected behavior
Expected pdf files to actually have content

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • Version [Alpha]
  • Type [CLI]

Additional context
Add any other context about the problem here.
@ObiSandwich
Copy link

See: #117

@Girbons
Copy link
Owner

Girbons commented Jan 3, 2023

closing as this is a duplicate as pointed out by @ObiSandwich

@Girbons Girbons closed this as completed Jan 3, 2023
@Girbons Girbons reopened this Jan 5, 2023
@Girbons
Copy link
Owner

Girbons commented Jan 5, 2023

I just find out that the previous logic to get the images was not working at all, so this is different from #117 😄

@Girbons Girbons closed this as completed in c9eb756 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Girbons @StrangeDOS @ObiSandwich