-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False Positive, and the Email link doesn't work #10
Comments
Thanks for your feedback :). we will definitely look into it for the link for the false positive button. For the secret detection part we are working on excluding Google API keys that are designed to be exposed publicly. |
Should be fixed right now thanks, closing the issue |
@ericfourrier should both issues be fixed or just the button? |
I also had this false positive. My API key is for javascript front end connected to firebase, which is intended to be public. |
Just got another false positive. For your reference this is what the Firebase console tells you to put in your web-apps:
|
I am still getting the false positive notification about allegedly exposed API keys, it's not critical though but necessary when using google firebase. |
There was just a false positive on one of my repos, where a Google APIKey is in the javascript.
I tried clicking the false positive button on the email, but that didn't work...
Google apiskeys embedded in javascript front-ends are available for the public to see in any-case as the JavaScript is run client side. :)
The text was updated successfully, but these errors were encountered: