Switched to constants (#2207)

Author: Huddie

Classes/Issues/IssueManagingContextController.swift

@@ -127,10 +127,10 @@ final class IssueManagingContextController: NSObject, ContextMenuDelegate {
             title = Constants.Strings.reviewers
             iconName = "reviewer"
         case .unlock:
-            title = NSLocalizedString("Unlock", comment: "")
+            title =  Constants.Strings.unlock
             iconName = "key"
         case .lock:
-            title = NSLocalizedString("Lock", comment: "")
+            title = Constants.Strings.lock
             iconName = "lock"
         case .reopen:
             title = Constants.Strings.reopen

Classes/Issues/Managing/IssueManagingSectionController.swift

@@ -19,37 +19,37 @@ ContextMenuDelegate {
     private enum Action {
         static let labels = IssueManagingActionModel(
             key: "tag",
-            label: NSLocalizedString("Labels", comment: ""),
+            label: Constants.Strings.labels,
             imageName: "tag",
             color: "3f88f7".color
         )
         static let milestone = IssueManagingActionModel(
             key: "milestone",
-            label: NSLocalizedString("Milestone", comment: ""),
+            label: Constants.Strings.milestone,
             imageName: "milestone",
             color: "6847ba".color
         )
         static let assignees = IssueManagingActionModel(
             key: "person",
-            label: NSLocalizedString("Assignees", comment: ""),
+            label: Constants.Strings.assignees,
             imageName: "person",
             color: "e77230".color
         )
         static let reviewers = IssueManagingActionModel(
             key: "reviewer",
-            label: NSLocalizedString("Reviewers", comment: ""),
+            label: Constants.Strings.reviewers,
             imageName: "reviewer",
             color: "50a451".color
         )
         static let lock = IssueManagingActionModel(
             key: "lock", // share key so lock/unlock just updates cell
-            label: NSLocalizedString("Lock", comment: ""),
+            label: Constants.Strings.lock,
             imageName: "lock",
             color: Styles.Colors.Gray.dark.color
         )
         static let unlock = IssueManagingActionModel(
             key: "lock", // share key so lock/unlock just updates cell
-            label: NSLocalizedString("Unlock", comment: ""),
+            label: Constants.Strings.unlock,
             imageName: "key",
             color: Styles.Colors.Gray.dark.color
         )

Classes/Views/Constants.swift

@@ -32,6 +32,8 @@ enum Constants {
         static let reopened = NSLocalizedString("Reopened", comment: "")
         static let unknown = NSLocalizedString("Unknown", comment: "")
         static let merged = NSLocalizedString("Merged", comment: "")
+        static let unlock = NSLocalizedString("Unlock", comment: "")
+        static let lock = NSLocalizedString("Lock", comment: "")
         static let locked = NSLocalizedString("Locked", comment: "")
         static let newIssue = NSLocalizedString("New Issue", comment: "")
         static let bullet = "\u{2022}"