Always update shortcuts on app launch (#2248)

Author: rnystrom

Classes/Systems/AppRouter/AppController.swift

@@ -30,6 +30,7 @@ final class AppController: LoginSplashViewControllerDelegate, GitHubSessionListe
         }
         splitViewController = controller
 
+        resetShortcuts()
         if let focused = sessionManager.focusedUserSession {
             resetViewControllers(userSession: focused)
             resetWatchSync(userSession: focused)
@@ -83,6 +84,10 @@ final class AppController: LoginSplashViewControllerDelegate, GitHubSessionListe
         watchAppSync?.start()
     }
 
+    private func resetShortcuts() {
+        ShortcutHandler.configure(sessionUsernames: sessionManager.userSessions.compactMap { $0.username })
+    }
+
     private func resetViewControllers(userSession: GitHubUserSession) {
         let appClient = GithubClient(userSession: userSession)
         self.appClient = appClient
@@ -140,7 +145,7 @@ final class AppController: LoginSplashViewControllerDelegate, GitHubSessionListe
             splitViewController.presentedViewController?.dismiss(animated: trueUnlessReduceMotionEnabled)
         }
 
-        ShortcutHandler.configure(sessionUsernames: manager.userSessions.compactMap { $0.username })
+        resetShortcuts()
         if let watch = watchAppSync {
             watch.sync(userSession: userSession)
         } else {

Classes/Systems/ShortcutHandler.swift

@@ -45,6 +45,8 @@ struct ShortcutHandler {
     }
 
     private static func generateItems(sessionUsernames: [String]) -> [UIApplicationShortcutItem] {
+        guard sessionUsernames.count > 0 else { return [] }
+
         var items = [
             UIApplicationShortcutItem.from(
                 route: SearchShortcutRoute(),