Don’t send haptic if it’s already marked as read (#1917)

maniramezan · rnystrom · commit f4ed93e9cb8f · 2018-07-26T09:15:43.000-04:00
This fixes #1893
diff --git a/Classes/Notifications/NotificationSectionController.swift b/Classes/Notifications/NotificationSectionController.swift
@@ -42,7 +42,13 @@ final class NotificationSectionController: ListSwiftSectionController<Notificati
     }
 
     func didTapRead(cell: NotificationCell) {
-        guard let id = value?.id else { return }
+        guard
+            let id = value?.id,
+            let model = modelController.githubClient.cache.get(id: id) as NotificationViewModel?,
+            !model.read
+        else {
+            return
+        }
         generator.impactOccurred()
         modelController.markNotificationRead(id: id)
     }

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,13 @@ final class NotificationSectionController: ListSwiftSectionController<Notificati`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`func didTapRead(cell: NotificationCell) {`
`45`		`- guard let id = value?.id else { return }`
	`45`	`+ guard`
	`46`	`+ let id = value?.id,`
	`47`	`+ let model = modelController.githubClient.cache.get(id: id) as NotificationViewModel?,`
	`48`	`+ !model.read`
	`49`	`+ else {`
	`50`	`+ return`
	`51`	`+ }`
`46`	`52`	`generator.impactOccurred()`
`47`	`53`	`modelController.markNotificationRead(id: id)`
`48`	`54`	`}`